Fix dependency installation in python.yml GitHub Action#656
Merged
Conversation
Member
Author
|
Hmm it seems that the rules I added for when to run python checks are incorrectly preventing those checks from running, even when we do actually edit files outside the excluded folders in some cases... hence problems were missed when merging previous PRs: on:
push:
paths-ignore:
- 'doc/**'
- '.github/ISSUE_TEMPLATE/**'
- 'README.md'
pull_request:
paths-ignore:
- 'doc/**'
- '.github/ISSUE_TEMPLATE/**'
- 'README.md'For now I'm going to remove these Edit: on second thought, the problem was simply that the openspiel PR only edited files within docs: https://github.com/gambitproject/gambit/pull/573/files |
Member
Author
|
…endencies for other tutorials
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
requirements.txtfiles used by tests and docs directlypygambititself in future thoughpaths-ignorein the GitHub action yml was wrongly preventing some checks from running. I don't think it's a big problem to remove this completely, whilst PRs take a long time to run, we don't do docs PRs in high enough volume/speed for this to be too much of a problem